arcHIVE-tech
/
SimpleCarousel-omeka-module
4
0
Fork 0
Code Issues 2 Pull Requests Projects Releases Wiki Activity

moved styles into css file, modified slider heigth for proper rendering issue #5 #6

Merged
chris merged 1 commits from fix/height-window-load into main 2021-09-08 12:01:10 +02:00
Conversation 2 Commits 1 Files Changed 2 +15 -17
jorge commented 2021-09-08 09:40:18 +02:00
Owner
Copy Link

to solve issue #5 and an upgrade for php version changed <?= to <?php

see commit e6e7cf44f5

to solve issue #5 and an upgrade for `php` version changed `<?=` to `<?php` see commit https://git.hangar.org/arcHIVE-tech/SimpleCarousel-omeka-module/commit/e6e7cf44f57159725620e58a1d2851feaf6b79f2
jorge added 1 commit 2021-09-08 09:40:18 +02:00
chris merged commit e47725e14e into main 2021-09-08 12:01:10 +02:00
chris commented 2021-09-08 12:03:39 +02:00
Owner
Copy Link

I have merged this but now I realize that..

<?php $variable ?>

does not echo the value

<?= $variable ?>

does echo the value

I will get this.

I have merged this but now I realize that.. ``` <?php $variable ?> ``` does not echo the value ``` <?= $variable ?> ``` does echo the value I will get this.
jorge commented 2021-09-10 12:21:05 +02:00
Author
Owner
Copy Link

thanks for the tip, i did mistake and thought it was deprecated, instead it wasn't

https://www.php.net/manual/en/function.echo.php

thanks for the tip, i did mistake and thought it was deprecated, instead it wasn't https://www.php.net/manual/en/function.echo.php
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: arcHIVE-tech/SimpleCarousel-omeka-module#6
No description provided.
Delete Branch "fix/height-window-load"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?