174 lines
6.0 KiB
PHP
174 lines
6.0 KiB
PHP
|
<?php
|
||
|
/**
|
||
|
* PHPCompatibility, an external standard for PHP_CodeSniffer.
|
||
|
*
|
||
|
* @package PHPCompatibility
|
||
|
* @copyright 2012-2019 PHPCompatibility Contributors
|
||
|
* @license https://opensource.org/licenses/LGPL-3.0 LGPL3
|
||
|
* @link https://github.com/PHPCompatibility/PHPCompatibility
|
||
|
*/
|
||
|
|
||
|
namespace PHPCompatibility\Sniffs\FunctionUse;
|
||
|
|
||
|
use PHPCompatibility\Sniffs\FunctionUse\RequiredToOptionalFunctionParametersSniff;
|
||
|
use PHP_CodeSniffer_File as File;
|
||
|
|
||
|
/**
|
||
|
* Detect missing required function parameters in calls to native PHP functions.
|
||
|
*
|
||
|
* Specifically when those function parameters used to be optional in older PHP versions.
|
||
|
*
|
||
|
* PHP version All
|
||
|
*
|
||
|
* @link https://www.php.net/manual/en/doc.changelog.php
|
||
|
*
|
||
|
* @since 8.1.0
|
||
|
* @since 9.0.0 Renamed from `OptionalRequiredFunctionParametersSniff` to `OptionalToRequiredFunctionParametersSniff`.
|
||
|
*/
|
||
|
class OptionalToRequiredFunctionParametersSniff extends RequiredToOptionalFunctionParametersSniff
|
||
|
{
|
||
|
|
||
|
/**
|
||
|
* A list of function parameters, which were optional in older versions and became required later on.
|
||
|
*
|
||
|
* The array lists : version number with true (required) and false (optional use deprecated).
|
||
|
*
|
||
|
* The index is the location of the parameter in the parameter list, starting at 0 !
|
||
|
* If's sufficient to list the last version in which the parameter was not yet required.
|
||
|
*
|
||
|
* @since 8.1.0
|
||
|
*
|
||
|
* @var array
|
||
|
*/
|
||
|
protected $functionParameters = array(
|
||
|
// Special case, the optional nature is not deprecated, but usage is recommended
|
||
|
// and leaving the parameter out will throw an E_NOTICE.
|
||
|
'crypt' => array(
|
||
|
1 => array(
|
||
|
'name' => 'salt',
|
||
|
'5.6' => 'recommended',
|
||
|
),
|
||
|
),
|
||
|
'parse_str' => array(
|
||
|
1 => array(
|
||
|
'name' => 'result',
|
||
|
'7.2' => false,
|
||
|
),
|
||
|
),
|
||
|
);
|
||
|
|
||
|
|
||
|
/**
|
||
|
* Determine whether an error/warning should be thrown for an item based on collected information.
|
||
|
*
|
||
|
* @since 8.1.0
|
||
|
*
|
||
|
* @param array $errorInfo Detail information about an item.
|
||
|
*
|
||
|
* @return bool
|
||
|
*/
|
||
|
protected function shouldThrowError(array $errorInfo)
|
||
|
{
|
||
|
return ($errorInfo['optionalDeprecated'] !== ''
|
||
|
|| $errorInfo['optionalRemoved'] !== ''
|
||
|
|| $errorInfo['optionalRecommended'] !== '');
|
||
|
}
|
||
|
|
||
|
|
||
|
/**
|
||
|
* Retrieve the relevant detail (version) information for use in an error message.
|
||
|
*
|
||
|
* @since 8.1.0
|
||
|
*
|
||
|
* @param array $itemArray Version and other information about the item.
|
||
|
* @param array $itemInfo Base information about the item.
|
||
|
*
|
||
|
* @return array
|
||
|
*/
|
||
|
public function getErrorInfo(array $itemArray, array $itemInfo)
|
||
|
{
|
||
|
$errorInfo = array(
|
||
|
'paramName' => '',
|
||
|
'optionalRecommended' => '',
|
||
|
'optionalDeprecated' => '',
|
||
|
'optionalRemoved' => '',
|
||
|
'error' => false,
|
||
|
);
|
||
|
|
||
|
$versionArray = $this->getVersionArray($itemArray);
|
||
|
|
||
|
if (empty($versionArray) === false) {
|
||
|
foreach ($versionArray as $version => $required) {
|
||
|
if ($this->supportsAbove($version) === true) {
|
||
|
if ($required === true && $errorInfo['optionalRemoved'] === '') {
|
||
|
$errorInfo['optionalRemoved'] = $version;
|
||
|
$errorInfo['error'] = true;
|
||
|
} elseif ($required === 'recommended' && $errorInfo['optionalRecommended'] === '') {
|
||
|
$errorInfo['optionalRecommended'] = $version;
|
||
|
} elseif ($errorInfo['optionalDeprecated'] === '') {
|
||
|
$errorInfo['optionalDeprecated'] = $version;
|
||
|
}
|
||
|
}
|
||
|
}
|
||
|
}
|
||
|
|
||
|
$errorInfo['paramName'] = $itemArray['name'];
|
||
|
|
||
|
return $errorInfo;
|
||
|
}
|
||
|
|
||
|
|
||
|
/**
|
||
|
* Generates the error or warning for this item.
|
||
|
*
|
||
|
* @since 8.1.0
|
||
|
*
|
||
|
* @param \PHP_CodeSniffer_File $phpcsFile The file being scanned.
|
||
|
* @param int $stackPtr The position of the relevant token in
|
||
|
* the stack.
|
||
|
* @param array $itemInfo Base information about the item.
|
||
|
* @param array $errorInfo Array with detail (version) information
|
||
|
* relevant to the item.
|
||
|
*
|
||
|
* @return void
|
||
|
*/
|
||
|
public function addError(File $phpcsFile, $stackPtr, array $itemInfo, array $errorInfo)
|
||
|
{
|
||
|
$error = 'The "%s" parameter for function %s() is missing. Passing this parameter is ';
|
||
|
if ($errorInfo['optionalRecommended'] === '') {
|
||
|
$error .= 'no longer optional. The optional nature of the parameter is ';
|
||
|
} else {
|
||
|
$error .= 'strongly recommended ';
|
||
|
}
|
||
|
|
||
|
$errorCode = $this->stringToErrorCode($itemInfo['name'] . '_' . $errorInfo['paramName']);
|
||
|
$data = array(
|
||
|
$errorInfo['paramName'],
|
||
|
$itemInfo['name'],
|
||
|
);
|
||
|
|
||
|
if ($errorInfo['optionalRecommended'] !== '') {
|
||
|
$error .= 'since PHP %s ';
|
||
|
$errorCode .= 'SoftRecommended';
|
||
|
$data[] = $errorInfo['optionalRecommended'];
|
||
|
} else {
|
||
|
if ($errorInfo['optionalDeprecated'] !== '') {
|
||
|
$error .= 'deprecated since PHP %s and ';
|
||
|
$errorCode .= 'SoftRequired';
|
||
|
$data[] = $errorInfo['optionalDeprecated'];
|
||
|
}
|
||
|
|
||
|
if ($errorInfo['optionalRemoved'] !== '') {
|
||
|
$error .= 'removed since PHP %s and ';
|
||
|
$errorCode .= 'HardRequired';
|
||
|
$data[] = $errorInfo['optionalRemoved'];
|
||
|
}
|
||
|
|
||
|
// Remove the last 'and' from the message.
|
||
|
$error = substr($error, 0, (\strlen($error) - 5));
|
||
|
}
|
||
|
|
||
|
$this->addMessage($phpcsFile, $error, $stackPtr, $errorInfo['error'], $errorCode, $data);
|
||
|
}
|
||
|
}
|