From ee46b3d3d8a3d6154be03076c56786ca97f4851d Mon Sep 17 00:00:00 2001
From: Kailash Nadh <kailash@nadh.in>
Date: Sat, 6 Feb 2021 18:58:11 +0530
Subject: [PATCH] Fix blank UI on forms pages when there are no public lists

---
 frontend/src/views/Forms.vue | 6 ++++++
 i18n/en.json                 | 9 +++++----
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/frontend/src/views/Forms.vue b/frontend/src/views/Forms.vue
index 9fb494f..d32ca32 100644
--- a/frontend/src/views/Forms.vue
+++ b/frontend/src/views/Forms.vue
@@ -2,7 +2,13 @@
   <section class="forms content relative">
     <h1 class="title is-4">{{ $t('forms.title') }}</h1>
     <hr />
+
     <b-loading v-if="loading.lists" :active="loading.lists" :is-full-page="false" />
+    <p v-else-if="publicLists.length === 0">
+      {{ $t('forms.noPublicLists') }}
+    </p>
+
+
     <div class="columns" v-else-if="publicLists.length > 0">
       <div class="column is-4">
         <h4>{{ $t('forms.publicLists') }}</h4>
diff --git a/i18n/en.json b/i18n/en.json
index e514c2c..727248e 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -92,6 +92,7 @@
     "email.unsubHelp": "Don't want to receive these e-mails?",
     "forms.formHTML": "Form HTML",
     "forms.formHTMLHelp": "Use the following HTML to show a subscription form on an external webpage. The form should have the email field and one or more `l` (list UUID) fields. The name field is optional.",
+    "forms.noPublicLists": "There are no public lists to generate a forms.",
     "forms.publicLists": "Public lists",
     "forms.publicSubPage": "Public subscription page",
     "forms.selectHelp": "Select lists to add to the form.",
@@ -257,12 +258,12 @@
     "public.privacyWipe": "Wipe your data",
     "public.privacyWipeHelp": "Delete all your subscriptions and related data from the database permanently.",
     "public.sub": "Subscribe",
-    "public.subTitle": "Subscribe",
-    "public.subName": "Name (optional)",
     "public.subConfirmed": "Subscribed successfully.",
     "public.subConfirmedTitle": "Confirmed",
+    "public.subName": "Name (optional)",
     "public.subNotFound": "Subscription not found.",
     "public.subPrivateList": "Private list",
+    "public.subTitle": "Subscribe",
     "public.unsub": "Unsubscribe",
     "public.unsubFull": "Also unsubscribe from all future e-mails.",
     "public.unsubHelp": "Do you want to unsubscribe from this mailing list?",
@@ -273,10 +274,10 @@
     "settings.duplicateMessengerName": "Duplicate messenger name: {name}",
     "settings.errorEncoding": "Error encoding settings: {error}",
     "settings.errorNoSMTP": "At least one SMTP block should be enabled",
-    "settings.general.enablePublicSubPage": "Enable public subscription page",
-    "settings.general.enablePublicSubPageHelp": "Show a public subscription page with all the public lists for people to subscribe.",
     "settings.general.adminNotifEmails": "Admin notification e-mails",
     "settings.general.adminNotifEmailsHelp": "Comma separated list of e-mail addresses to which admin notifications such as import updates, campaign completion, failure etc. should be sent.",
+    "settings.general.enablePublicSubPage": "Enable public subscription page",
+    "settings.general.enablePublicSubPageHelp": "Show a public subscription page with all the public lists for people to subscribe.",
     "settings.general.faviconURL": "Favicon URL",
     "settings.general.faviconURLHelp": "(Optional) full URL to the static favicon to be displayed on user facing view such as the unsubscription page.",
     "settings.general.fromEmail": "Default `from` email",