arcHIVE-tech
/
fixes
4
0
Fork 0
Code Issues 13 Pull Requests Projects Releases Wiki Activity

dimensions of multiple items are not calculated correctly #16

New Issue
Closed
opened 2021-08-28 16:51:04 +02:00 by chris · 4 comments
chris commented 2021-08-28 16:51:04 +02:00
Owner
Copy Link

We need a common mechanism to handle rendering and on window resizing of all iframes present on a page.

We need a common mechanism to handle rendering and on window resizing of all iframes present on a page.
chris commented 2021-08-29 09:26:50 +02:00
Author
Owner
Copy Link

Items of different types on the same page cause dimension problems.

The idea might be to inject w/h into the iframe before it is rendered.

Items of different types on the same page cause dimension problems. The idea might be to inject w/h into the iframe before it is rendered.
jorge commented 2021-08-29 14:21:33 +02:00
Owner
Copy Link

could it be to hold the iframe at 100% width of the upper container?

then it would be held inside the main area that adapts to different screen sizes?

could it be to hold the iframe at 100% width of the upper container? then it would be held inside the main area that adapts to different screen sizes?
chris commented 2021-08-31 15:54:48 +02:00
Author
Owner
Copy Link

When using oembed with Vimeo and Sketchfab, "width" and "height" are included in the returned iframe attributes in pixels. But we want width to be 100% (or some other percentage defined by our users). So we need a way to calulated that.

My proposal is to, before rendering, calulate the ratio using the dimensions returned by the oembed API and then, change the width to 100% (or what ever) and remove the height. Then, on the client, use jQuery to get the width in pixels of the iframe and use the ratio to calulate and insert the height

I have included this in both the Vimeo and Sketchfab modules. It works.

When using oembed with Vimeo and Sketchfab, "width" and "height" are included in the returned iframe attributes in pixels. But we want width to be 100% (or some other percentage defined by our users). So we need a way to calulated that. My proposal is to, before rendering, calulate the ratio using the dimensions returned by the oembed API and then, change the width to 100% (or what ever) and remove the height. Then, on the client, use jQuery to get the width in pixels of the iframe and use the ratio to calulate and insert the height I have included this in both the Vimeo and Sketchfab modules. It works.
chris commented 2021-09-02 13:47:58 +02:00
Author
Owner
Copy Link

This new module correctly handles the dimensions of embeded media

https://git.hangar.org/arcHIVE-tech/oEmbed-omeka-module

Compatible media types:

  • Vimeo
  • Youtube
  • Sketchfab
This new module correctly handles the dimensions of embeded media https://git.hangar.org/arcHIVE-tech/oEmbed-omeka-module Compatible media types: * Vimeo * Youtube * Sketchfab
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: arcHIVE-tech/fixes#16
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?